-
Notifications
You must be signed in to change notification settings - Fork 391
upcoming: [UIE-9826] - Add reusable Product Selection Card component for Marketplace #13247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/manager/src/features/Marketplace/MarketplaceLanding/ProductSelectionCard.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Marketplace/MarketplaceLanding/ProductSelectionCard.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Marketplace/MarketplaceLanding/ProductSelectionCard.tsx
Outdated
Show resolved
Hide resolved
| sxCardBase={(theme) => ({ | ||
| alignItems: 'flex-start', | ||
| flexDirection: 'column', | ||
| minHeight: '280px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the card has a fixed dimension of 400 x 280 px. Could we set the Width too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think SelectionCard is already configured to work properly on different screen sizes when used in grids. Adding a fixed width could break its responsiveness. Since this card is used the same way in other parts of CM, it should behave consistently throughout so I think we can keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A confirmation with UX would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have Figma UX mocks available for tablet and mobile views with different responsive widths, so I think we're good to go. cc @davyd-akamai
tvijay-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your work here @pmakode-akamai.
Cloud Manager UI test results🎉 855 passing tests on test run #15 ↗︎
|
Description 📝
Add reusable Product Card component for Marketplace
Changes 🔄
MarketplaceLandingdirectoryScope 🚢
Target release date 🗓️
N/A
Preview 📷
Note
Logos shown in the preview are used only as examples for testing. The actual product logos will be provided by the API
How to test 🧪
Prerequisites
Enable MarketplaceV2 feature flag
Use the below example usage code in the
MarketplaceLandingcomponent for testing (use actual sample data or hardcoded values):Example usage code
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅